Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
Async::Task#defer_stop{}
which can be used to implement graceful shutdown.In a typical client server architecture, it's common for a server process to handle discrete requests. When it is time to shut down, we should try to terminate after finishing the response.
Async uses
Async::Task#stop
to request a sub-system to exit. Exiting while writing a response or closing a connection is more likely to cause problems for the client. By deferring stop, we enable services to implement graceful shutdown timeout.See socketry/async-http#153 for proposed usage.
Types of Changes
Contribution