Ensure h2 Websocket requests include :scheme #60
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR causes
:scheme
to be properly populated for http2 Websocket requests.:scheme
is presently showing up to the server as an empty string (which is odd, since I'd expect it to benil
instead--I did not chase this down).According to RFC 8441, section 4, bullet 2,
:scheme
must be present for h2 WS requests (which contrasts to other uses of h2CONNECT
, where:scheme
is expected to be omitted).This also adds tests for the presence and validity of
authority
,path
, andprotocol
.Types of Changes
Contribution