Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve validation of Websocket requests #59

Merged
merged 2 commits into from
Dec 9, 2023
Merged

Improve validation of Websocket requests #59

merged 2 commits into from
Dec 9, 2023

Conversation

zarqman
Copy link
Contributor

@zarqman zarqman commented Sep 13, 2023

This PR improves the validation of Websocket requests to:

  • Verify response.protocol (aka Upgrade) for h11
  • Verify Connection for h11

It also adds tests for the existing verification of response.status for both h11 and h2.

This is based on RFC 6455, page 19, items 2 (Upgrade) and 3 (Connection).

Types of Changes

  • Performance improvement.

Contribution

ioquatix
ioquatix approved these changes Dec 9, 2023
View reviewed changes
Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ioquatix ioquatix merged commit 6146dd1 into socketry:main Dec 9, 2023
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioquatix ioquatix ioquatix approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zarqman @ioquatix