Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better public .connected property #41

Closed
rauchg opened this issue Aug 30, 2010 · 1 comment
Closed

Better public .connected property #41

rauchg opened this issue Aug 30, 2010 · 1 comment

Comments

@rauchg
Copy link
Contributor

rauchg commented Aug 30, 2010

Right now .connected doesn't indicate if the connection is considered disconnected, but rather if there's an open request for a client. If the client is in a a long-polling disconnection, .connected will be false even though the "socket" is still considered connected.

finalized should be removed, connected should be named open or similar (or maybe use a readyState property with number codes), and an actual connected with the expected behavior should be introduced.
@rauchg
Copy link
Contributor Author

rauchg commented Sep 5, 2010

.connected renamed to ._open, and adopted proper connected (closed by d041572)
example/client updated to latest socket.io client

@peteruithoven peteruithoven mentioned this issue Jan 15, 2015
Closed
@snyk-bot snyk-bot mentioned this issue Mar 8, 2020
Open
@snyk-bot snyk-bot mentioned this issue Oct 26, 2020
Open
This was referenced Jan 8, 2021
Open
Open
This was referenced Oct 28, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue May 18, 2022
Open
@tjenkinson tjenkinson mentioned this issue Sep 30, 2022
Open
@abinabrahamanchery abinabrahamanchery mentioned this issue Oct 30, 2022
Open
@snyk-bot snyk-bot mentioned this issue Oct 31, 2022
Open
@tjenkinson tjenkinson mentioned this issue Jan 9, 2023
Open
@abinabrahamanchery abinabrahamanchery mentioned this issue Jan 10, 2023
Open
darrachequesne added a commit that referenced this issue Jul 4, 2024
@darrachequesne
[chore] Bump zuul to 3.11.0 & zuul-ngrok to 4.0.0 (#41)
aa187cd
darrachequesne pushed a commit that referenced this issue Jul 8, 2024
@rauchg
Merge pull request #41 from rase-/fix/parse-error
3f7dde9 
Fix parse error
darrachequesne pushed a commit that referenced this issue Jul 8, 2024
@TooTallNate
add LICENSE file
2999c52 
Closes #41.
darrachequesne added a commit that referenced this issue Jul 8, 2024
@darrachequesne
[feature] Add clientRooms method (#41)
ffadfa6 
That method returns the list of rooms a given socket has joined. It is
intended to be used by other adapters, without them needing to access
the innards of the adapter.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rauchg