Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[READY] Fix syntax in switch_config_loader #836

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

owendelong
Copy link
Collaborator

@owendelong owendelong commented Feb 6, 2025

Description of PR

Fixes regression introduced in: #825

Fix stupid in switch_config_loader:126

And later in

$ ./scripts/switch_config_loader -l -b
Global symbol "$Loader" requires explicit package name (did you forget to declare "my $Loader"?) at ./scripts/switch_config_loader line 233.
Global symbol "$Loader" requires explicit package name (did you forget to declare "my $Loader"?) at ./scripts/switch_config_loader line 234.
Execution of ./scripts/switch_config_loader aborted due to compilation errors.

Previous Behavior

Owen must have suffered from a bout of python brain and wrote syntactically (and grammatically) terrible code.

New Behavior

PERL will digest it and do what was intended.

Tests

Testing is for people who don't write perfect code.

@owendelong owendelong changed the title Fix syntax in switch_config_loader [READY] Fix syntax in switch_config_loader Feb 6, 2025
@sarcasticadmin sarcasticadmin changed the title [READY] Fix syntax in switch_config_loader [WAIT] Fix syntax in switch_config_loader Feb 6, 2025
@sarcasticadmin
Copy link
Member

Getting the following error running switch_config_loader:

$ ./scripts/switch_config_loader -l -b
Global symbol "$Loader" requires explicit package name (did you forget to declare "my $Loader"?) at ./scripts/switch_config_loader line 233.
Global symbol "$Loader" requires explicit package name (did you forget to declare "my $Loader"?) at ./scripts/switch_config_loader line 234.
Execution of ./scripts/switch_config_loader aborted due to compilation errors.

This was causing `./scripts/switch_config_loader -l -b` to fail
@sarcasticadmin
Copy link
Member

switch_config_loader again working as expected:

$ ./scripts/switch_config_loader -l -b
...
Passing Rm209-210
Passing Rm211
Passing Rm214
Passing SpareJ
Expansion ends
List expansion yielded 37 Switch names.
opt_t OK
opt_c OK
dev OK
Got past opt_t
Got to check for opt_b
Passed IP: (192.168.255.76)
Possibly default IP: (192.168.255.76)
Looking for switch (192.168.255.76) on line.
        Ping result: 0
        Ping result: 0
        Ping result: 0
^C

Copy link
Member

@sarcasticadmin sarcasticadmin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix @owendelong

@sarcasticadmin sarcasticadmin changed the title [WAIT] Fix syntax in switch_config_loader [READY] Fix syntax in switch_config_loader Feb 6, 2025
@sarcasticadmin sarcasticadmin merged commit 4cfd988 into master Feb 6, 2025
2 checks passed
@sarcasticadmin sarcasticadmin deleted the od_pre22x_p1 branch February 6, 2025 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants