feat: allow namespaced component names #683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e436220 to
7776b47
Compare
jgresty
reviewed
Jan 30, 2025
jgresty
reviewed
Jan 30, 2025
7776b47 to
dfaca7c
Compare
OpenAPI generated by Typespec will use namespace-qualified component names in the generated OpenAPI, when types are in a different namespace from that of the OpenAPI spec. Additionally, components derived from model properties such as parameters or headers use the property name as a suffix. This updates the componentNameCase rule to allow PascalCase component names with an optional dot.case namespace prefix and optional snake_case suffix. Updated the sweater-comb standards documentation with this change. DGP-50
dfaca7c to
c22f0ff
Compare
jgresty
approved these changes
Feb 3, 2025
|
🎉 This PR is included in version 3.4.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenAPI generated by Typespec will use namespace-qualified component names in the generated OpenAPI, when types are in a different namespace from that of the OpenAPI spec.
This updates the componentNameCase rule to allow PascalCase component names with a dot.case namespace prefix.
DONE: figure out how to deal with TypeSpec materialized component names for parameters.