feat: improve-remediation #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
733d9be to
ef2b1ca
Compare
gitphill
reviewed
Dec 17, 2019
test/remediation.spec.ts
Outdated
| beforeEach(() => { | ||
| activateVirtualenv('remediation'); | ||
| // const manifests = { 'requirements.txt': 'Jinja==2.7.2' }; | ||
| // const upgrades = { 'jinja@2.7.2': { upgradeTo: 'jinja@2.8.1' } }; |
There was a problem hiding this comment.
Oops! Yes, will remove.
gitphill
reviewed
Dec 17, 2019
lib/index.ts
Outdated
| return originalText; | ||
| } | ||
|
|
||
| const newVersion = upgrade.upgradeTo.split('@')[1]; |
There was a problem hiding this comment.
are we sure the package name will never have a '@' in the name?
There was a problem hiding this comment.
I believe so. See
https://pypi.org/search/?q=%22s%22&o= vs https://pypi.org/search/?q=%22%40%22&o=
gitphill
approved these changes
Dec 17, 2019
This patch is a rewrite of the remediation implementation. It makes several changes: - Remove the reliance on `inspect`, and instead get top level deps by parsing the manifest file. This should be significantly quicker than a pip install, making the fix process much faster for larger projects - Change the parser to attempt to better preserve package casing, version comparators, and extras (comments, markers, etc) - Update tests and add new tests. In a couple of cases, this actually involves fixing the test fixture, as the fixture itself was making changes such as package name casing, adding extra new lines to the manifest etc.
ef2b1ca to
61cfb58
Compare
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is a rewrite of the remediation implementation. It makes several changes:
inspect, and instead get top level deps by parsing the manifest file. This should be significantly quicker than a pip install, making the fix process much faster for larger projects