feat: support setup.py as a return target file #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1d1d0fb to
59ee45b
Compare
|
|
59ee45b to
2870c3f
Compare
orsagie
reviewed
Dec 1, 2019
lib/inspect-implementation.ts
Outdated
| @@ -18,8 +18,9 @@ export function getMetaData( | |||
| name: 'snyk-python-plugin', | |||
| runtime: output.replace('\n', ''), | |||
| // specify targetFile only in case of Pipfile | |||
| targetFile: | |||
| path.basename(targetFile) === 'Pipfile' ? targetFile : undefined, | |||
| targetFile: path.basename(targetFile).match(/^Pipfile|setup\.py$/) | |||
There was a problem hiding this comment.
this also matches Pipfilexyz and blahsetup.py
2870c3f to
90a4140
Compare
orsagie
approved these changes
Dec 1, 2019
|
🎉 This PR is included in version 1.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add return
targetFilefrom pluginsetup.pyif it's the project manifest