Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support another kind of setuptools import #207

Merged
merged 1 commit into from
May 8, 2023

Conversation

admons
Copy link
Contributor

@admons admons commented May 8, 2023

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

today we only support "from setuptools import setup; setup(...)", this change adds support for "import setuptools; setuptools.setup(...)"

@admons admons marked this pull request as ready for review May 8, 2023 10:10
@admons admons requested a review from a team as a code owner May 8, 2023 10:10
today we only support "from setuptools import setup; setup(...)", this change adds support for "import setuptools; setuptools.setup(...)"
@admons admons force-pushed the fix/setup-py-another-setuptools-import branch from 0a57279 to ba14e84 Compare May 8, 2023 10:11
@admons
Copy link
Contributor Author

admons commented May 8, 2023

This is related to SUP-751

Copy link
Contributor

@dotkas dotkas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried to search github for other ways to import, but did not find any, so I think it's good.

@admons admons merged commit 3266372 into master May 8, 2023
@admons admons deleted the fix/setup-py-another-setuptools-import branch May 8, 2023 11:18
@snyksec
Copy link

snyksec commented May 8, 2023

🎉 This PR is included in version 1.25.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants