Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed dependencies #201

Closed
wants to merge 1 commit into from
Closed

Embed dependencies #201

wants to merge 1 commit into from

Conversation

alexey-medvedchikov
Copy link

@alexey-medvedchikov alexey-medvedchikov commented Mar 13, 2023 •
edited
Loading

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

This PR makes sure that all required for the plugin Python packages are vendored. This way we don't depend on what virtualenv or customer will install.

Known caveats:

  • This doesn't include setuptools as it is hard to vendor and overriden in a very rare case.
  • The version of vendored packages is not the latest because they must work with both Py2 and Py3, but it is possible to split the vendoring in the pysrc scripts and make 2 separate vendoring directories.

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@CLAassistant
Copy link

CLAassistant commented Mar 13, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@alexey-medvedchikov alexey-medvedchikov changed the title SUP-556: Embed dependencies Embed dependencies Mar 13, 2023
@alexey-medvedchikov alexey-medvedchikov force-pushed the vendor-deps branch 28 times, most recently from 52e356f to aab45c8 Compare March 15, 2023 12:41
@alexey-medvedchikov alexey-medvedchikov force-pushed the vendor-deps branch 18 times, most recently from 2fe30a4 to 42fdf02 Compare March 15, 2023 18:29
@alexey-medvedchikov alexey-medvedchikov marked this pull request as ready for review March 15, 2023 18:52
@alexey-medvedchikov alexey-medvedchikov requested a review from a team as a code owner March 15, 2023 18:52
@dotkas dotkas self-requested a review March 16, 2023 07:42
admons added a commit that referenced this pull request Mar 16, 2023
@admons
fix: fix new setuptools
8c981a4 
new versions of setuptools uses a newer version of "packaging" that doesn't support older ranges (i.e. 'pytz>dev')
this vendor a previous version of the packages with breaking changes
this commit is a partial change inspired by #201
@admons admons mentioned this pull request Mar 16, 2023
Merged
3 tasks
admons added a commit that referenced this pull request Mar 16, 2023
@admons
fix: fix new setuptools
789e1c0 
new versions of setuptools uses a newer version of "packaging" that doesn't support older ranges (i.e. 'pytz>dev')
this vendor a previous version of the packages with breaking changes
this commit is a partial change inspired by #201
@admons
Copy link
Contributor

admons commented Mar 19, 2023

This change was superseded by #203

@admons admons closed this Mar 19, 2023
@admons admons deleted the vendor-deps branch March 19, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotkas dotkas Awaiting requested review from dotkas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexey-medvedchikov @CLAassistant @admons @dotkas