Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use poetry-lock file as a target file for poetry project #143

Merged

Conversation

jan-stehlik
Copy link
Contributor

@jan-stehlik jan-stehlik commented May 5, 2021

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

As a part of this PR we we will pass poetry.lock file to this plugin as opposed to pyproject.toml. This is because pyproject.toml is not a reliable manifest file (see https://github.com/snyk/snyk/issues/1802) and therefore we need to use poetry.lock as a traget file. This is a breaking change

New published version has to be integrated into snyk/cli#1879

How should this be manually tested?

  1. checkout this branch fix: fix invalid poetry detection cli#1879
  2. link snyk-python-plugin to snyk repo - make sure you are using the same node versions in both repos
  3. run tests in fix: fix invalid poetry detection cli#1879

What are the relevant tickets?

LOKI-280

@jan-stehlik jan-stehlik requested a review from a team as a code owner May 5, 2021 16:54
@jan-stehlik jan-stehlik requested a review from tonidevine1 May 5, 2021 16:54
@CLAassistant
Copy link

CLAassistant commented May 5, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@orsagie orsagie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jan-stehlik jan-stehlik merged commit 0f466d0 into master May 6, 2021
@jan-stehlik jan-stehlik deleted the fix/parse-poetry-dependencies-based-on-poetry-lock branch May 6, 2021 08:56
@orsagie
Copy link
Contributor

orsagie commented May 6, 2021

🎉

@snyksec
Copy link

snyksec commented May 6, 2021

🎉 This PR is included in version 1.19.9 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants