fix: add correct lesson url for license issues [IDE-971] #782
+69
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+240
to
+242
| if !strings.Contains(lesson.Url, "?loc=ide") { | ||
| lesson.Url += "?loc=ide" | ||
| } |
There was a problem hiding this comment.
this should be quite an easy thing to test :)
There was a problem hiding this comment.
Good point, the test for the learn already included this but I will also add a test for lessons which are not coming from license issues
bastiandoetsch
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Learn links in the Issue Description Panel for License type Issues were always wrong, this was fixed with adding a link to URL: https://learn.snyk.io/lesson/license-policy-management/ when a License type issue is encountered.
Checklist