fix: fail early for top level deps out of sync pnpm and updated tests #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gemaxim
commented
Aug 13, 2024
| @@ -34,15 +34,6 @@ export const getPnpmChildNode = ( | |||
| resolvedVersion = pkgData.version; | |||
| } | |||
| if (!pkgs[childNodeKey]) { | |||
| if (lockfileParser.isWorkspaceLockfile()) { | |||
There was a problem hiding this comment.
This is not needed anymore because workspace importers are added to extracted packages and we should fail with OutOfSync if not found there
dotkas
approved these changes
Aug 13, 2024
|
🎉 This PR is included in version 1.58.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does
We should throw OutOfSync early if top level deps were not found in extracted lockfile packages.
Updated tests for pnpm/npm/yarn: we shouldn't use try-catch to test a failing scenario because if if the function doesn't fail as expected the test still passes