Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(code): Support single file test for golang native implementation #5731

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

PeterSchafer
Copy link
Collaborator

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

This fix closes the gap between the legacy code test implementation and the golang native implementation by supporting to test a single file in addition to a folder.

Where should the reviewer start?

snyk/go-application-framework#305

How should this be manually tested?

On a CCI enabled org run snyk code test file.js

@PeterSchafer PeterSchafer requested a review from a team as a code owner February 12, 2025 09:27
Copy link
Contributor

github-actions bot commented Feb 12, 2025

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/acceptance/snyk-code/snyk-code.spec.ts

Generated by 🚫 dangerJS against d7881f1

@j-luong j-luong force-pushed the chore/CLI-369_codesinglefile branch from 6a3105a to 65b8011 Compare February 12, 2025 12:22
@j-luong j-luong force-pushed the chore/CLI-369_codesinglefile branch from 65b8011 to b191192 Compare February 12, 2025 13:50
@j-luong j-luong enabled auto-merge February 12, 2025 14:14
@PeterSchafer PeterSchafer force-pushed the chore/CLI-369_codesinglefile branch from b191192 to d7881f1 Compare February 12, 2025 15:39
@j-luong j-luong merged commit ecc986d into main Feb 12, 2025
7 checks passed
@j-luong j-luong deleted the chore/CLI-369_codesinglefile branch February 12, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants