Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use new implementation for golang native code consistent ignores #5713

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

PeterSchafer
Copy link
Collaborator

@PeterSchafer PeterSchafer commented Feb 5, 2025

Pull Request Submission Checklist

  • Follows CONTRIBUTING guidelines
  • Includes detailed description of changes
  • Contains risk assessment (Low | Medium | High)
  • Highlights breaking API changes (if applicable)
  • Links to automated tests covering new functionality
  • Includes manual testing instructions (if necessary)
  • Updates relevant GitBook documentation (PR link: ___)

What does this PR do?

This PR replaces the implementation of the golang native code consistent ignores implementation and subsequent data processing pipeline. The implementation is behind a feature flag and is functional equivalent to the old implementation. It does add additional fingerprints to the Sarif data and inherently has improved performance.

Due to the changes being behind a feature flag, the changes are of low risk.

Where should the reviewer start?

How should this be manually tested?

@PeterSchafer PeterSchafer requested a review from a team as a code owner February 5, 2025 16:40
Copy link
Contributor

github-actions bot commented Feb 5, 2025

Warnings
⚠️

Since the CLI is unifying on a standard and improved tooling, we're starting to migrate old-style imports and exports to ES6 ones.
A file you've modified is using either module.exports or require(). If you can, please update them to ES6 import syntax and export syntax.
Files found:

  • test/jest/acceptance/snyk-code/snyk-code.spec.ts
⚠️ There are multiple commits on your branch, please squash them locally before merging!
⚠️

"chore: replace orchestration APIs by test API for native code.test implementation" is too long. Keep the first line of your commit message under 72 characters.

Generated by 🚫 dangerJS against 898de0d

@PeterSchafer PeterSchafer merged commit 496998a into release-candidate Feb 5, 2025
5 checks passed
@PeterSchafer PeterSchafer deleted the hotfix/consistent_ignores branch February 5, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants