Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disable tracking via Segment and Amplitude for instances hosted outside the US #5050

Closed
wants to merge 1 commit into from

Conversation

acke
Copy link
Contributor

@acke acke commented Feb 9, 2024

Pull Request Submission

We have a new release of Language Server here:
https://github.com/snyk/snyk-ls/releases/tag/v20240209.115701

What does this PR do?

IDE-24 Disable Tracking via Segment and Amplitude for NON-MT-US customers

Where should the reviewer start?

How should this be manually tested?

Any background context you want to provide?

What are the relevant tickets?

Screenshots

Additional questions

@acke acke requested a review from a team as a code owner February 9, 2024 15:43
@thisislawatts
Copy link
Member

thisislawatts commented Feb 9, 2024

issue(blocking): @acke would you be able to adjust the commit message so that we communicate the customer value/impact? We use the commit messages to generate our release notes, see here: https://github.com/snyk/cli/releases

Suggestion:
fix: Disable tracking via Segment and Amplitude for customers hosted outside US

@acke acke force-pushed the fix/upgrade-ls branch 2 times, most recently from 291d99c to 53aeb19 Compare February 12, 2024 09:19
@acke
Copy link
Contributor Author

acke commented Feb 12, 2024

The commit message is updated.

@cat2608 cat2608 changed the title fix: upgrade LS fix: disable tracking via Segment and Amplitude for instances hosted outside the US Feb 12, 2024
@PeterSchafer PeterSchafer enabled auto-merge (squash) February 12, 2024 14:06
@acke acke force-pushed the fix/upgrade-ls branch 3 times, most recently from e94641b to 6770017 Compare February 14, 2024 14:10
@chdorner-snyk
Copy link
Contributor

Closing this as #5052 has already bumped the snyk-ls dependency to a version which includes the change we were looking to integrate

auto-merge was automatically disabled February 21, 2024 09:14

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants