Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1518381: enabling oob telemetry for local testing #1878

Merged
merged 2 commits into from
Jul 12, 2024
Merged

SNOW-1518381: enabling oob telemetry for local testing #1878

merged 2 commits into from
Jul 12, 2024

Conversation

sfc-gh-aling
Copy link
Contributor

@sfc-gh-aling sfc-gh-aling commented Jul 3, 2024 •
edited
Loading

  1. Which Jira issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes SNOW-1518381

to coordinate the change coming from python connector snowflakedb/snowflake-connector-python#1991, we overwrite the enable/disable methods to turn oob telemetry on for local testing

  1. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
      • If this test skips Local Testing mode, I'm requesting review from @snowflakedb/local-testing
    • I am adding new logging messages
    • I am adding a new telemetry message
    • I am adding new credentials
    • I am adding a new dependency
    • If this is a new feature/behavior, I'm adding the Local Testing parity changes.

  2. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@github-actions github-actions bot added the local testing Local Testing issues/PRs label Jul 3, 2024
@sfc-gh-aling sfc-gh-aling mentioned this pull request Jul 10, 2024
Merged
7 tasks
@sfc-gh-aling sfc-gh-aling changed the title enabling oob telemetry for local testing SNOW-1518381: enabling oob telemetry for local testing Jul 11, 2024
@sfc-gh-aling sfc-gh-aling marked this pull request as ready for review July 11, 2024 17:46
@sfc-gh-aling sfc-gh-aling requested a review from a team as a code owner July 11, 2024 17:46
@sfc-gh-aling sfc-gh-aling force-pushed the SNOW-1518381-disabling-general-oob-telemetry-in-python-driver-while-exposing-the-capability-to-local-testing branch from ecb25ae to d16dee1 Compare July 12, 2024 18:10
@sfc-gh-aling sfc-gh-aling added the NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md label Jul 12, 2024
@sfc-gh-aling sfc-gh-aling merged commit b2e7a0e into main Jul 12, 2024
33 of 34 checks passed
@sfc-gh-aling sfc-gh-aling deleted the SNOW-1518381-disabling-general-oob-telemetry-in-python-driver-while-exposing-the-capability-to-local-testing branch July 12, 2024 20:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-aalam sfc-gh-aalam sfc-gh-aalam approved these changes

@sfc-gh-jrose sfc-gh-jrose sfc-gh-jrose approved these changes

@sfc-gh-yixie sfc-gh-yixie Awaiting requested review from sfc-gh-yixie sfc-gh-yixie is a code owner automatically assigned from snowflakedb/snowpark-python-api-reviewers

Assignees
No one assigned
Labels
local testing Local Testing issues/PRs NO-CHANGELOG-UPDATES This pull request does not need to update CHANGELOG.md
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-aling @sfc-gh-aalam @sfc-gh-jrose