Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1898856: Make test getMaxBinaryLiteralLength and getMaxCharLiteralLength more robust #2048

Merged
merged 1 commit into from
Jan 27, 2025
Merged

SNOW-1898856: Make test getMaxBinaryLiteralLength and getMaxCharLiteralLength more robust #2048

merged 1 commit into from
Jan 27, 2025

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

@sfc-gh-dprzybysz sfc-gh-dprzybysz commented Jan 27, 2025 •
edited
Loading

Overview

SNOW-1898856

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner January 27, 2025 08:22
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title SNOW-1898856: Make test getMaxBinaryLiteralLength and getMaxCharLiter… SNOW-1898856: Make test getMaxBinaryLiteralLength and getMaxCharLiteralLength more robust Jan 27, 2025
@sfc-gh-dprzybysz sfc-gh-dprzybysz mentioned this pull request Jan 27, 2025
Merged
5 tasks
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 3236d98 into master Jan 27, 2025
140 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1898856-make-test-getMaxBinaryLiteralLength-more-robuse branch January 27, 2025 12:03
@github-actions github-actions bot locked and limited conversation to collaborators Jan 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-dprzybysz @sfc-gh-pfus @sfc-gh-mkubik