SNOW-1846830 allow triple slash file prefix (file:///) #2033
+28
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently triple slash prefix doesn't work on windows as it driver resolves it to something like
/C:/path/to/file
and such path doesn't exist. The primary reason for this is that driver simply cutsfile://
prefix from the string provided by user and the result of this operation is directly passed to the upload function. The quick fix is using the java.io.File parsed path.Without the fix from PR#2035 the upload with
file:///
doesn't throw an error but as the test result shows - no file is being uploaded.Overview
SNOW-1863648
Pre-review self checklist
master
branchmvn -P check-style validate
)mvn verify
and inspecttarget/japicmp/japicmp.html
)SNOW-XXXX: