Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-1804062: Explicitly exclude old netty-common from transitive dependencies #2014

Merged
merged 2 commits into from
Jan 7, 2025
Merged

SNOW-1804062: Explicitly exclude old netty-common from transitive dependencies #2014

merged 2 commits into from
Jan 7, 2025

Conversation

sfc-gh-dprzybysz
Copy link
Collaborator

Overview

SNOW-1804062

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

@sfc-gh-dprzybysz sfc-gh-dprzybysz requested a review from a team as a code owner December 20, 2024 08:59
@sfc-gh-dszmolka sfc-gh-dszmolka mentioned this pull request Dec 20, 2024
Closed
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1804062-explicitly-exclude-old-netty-common-from-transitive-dependencies branch from 9f97d71 to c309ed8 Compare December 20, 2024 11:52
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 8b5e51e into master Jan 7, 2025
126 of 142 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1804062-explicitly-exclude-old-netty-common-from-transitive-dependencies branch January 7, 2025 06:35
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-mkubik sfc-gh-mkubik sfc-gh-mkubik approved these changes

@sfc-gh-astachowski sfc-gh-astachowski sfc-gh-astachowski approved these changes

@sfc-gh-pfus sfc-gh-pfus sfc-gh-pfus approved these changes

@sfc-gh-pbulawa sfc-gh-pbulawa sfc-gh-pbulawa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sfc-gh-dprzybysz @sfc-gh-pbulawa @sfc-gh-pfus @sfc-gh-astachowski @sfc-gh-mkubik