Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1739611 add oauth and okta automated tests #1994

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

sfc-gh-akolodziejczyk
Copy link
Contributor

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk commented Dec 10, 2024

Overview

SNOW-1739611
Adding tests for okta and ouath

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Issue: #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk force-pushed the SNOW-1739611-other-methods branch 4 times, most recently from 31c0dc3 to d379857 Compare December 11, 2024 13:46
@sfc-gh-dprzybysz sfc-gh-dprzybysz force-pushed the SNOW-1739611-other-methods branch 2 times, most recently from fde1fee to 7add6e7 Compare December 12, 2024 09:01
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk marked this pull request as ready for review December 12, 2024 11:52
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk requested a review from a team as a code owner December 12, 2024 11:52
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk merged commit b3a2763 into master Dec 17, 2024
139 of 142 checks passed
@sfc-gh-akolodziejczyk sfc-gh-akolodziejczyk deleted the SNOW-1739611-other-methods branch December 17, 2024 09:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants