Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNOW-1454054: Add check of user permission for token file #1835

Merged
merged 2 commits into from
Jul 22, 2024

Conversation

sfc-gh-pmotacki
Copy link
Contributor

@sfc-gh-pmotacki sfc-gh-pmotacki commented Jul 19, 2024

Overview

SNOW-1454054

Pre-review self checklist

  • PR branch is updated with all the changes from master branch
  • The code is correctly formatted (run mvn -P check-style validate)
  • New public API is not unnecessary exposed (run mvn verify and inspect target/japicmp/japicmp.html)
  • The pull request name is prefixed with SNOW-XXXX:
  • Code is in compliance with internal logging requirements

External contributors - please answer these questions before submitting a pull request. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency or upgrading an existing one
    • I am adding new public/protected component not marked with @SnowflakeJdbcInternalApi (note that public/protected methods/fields in classes marked with this annotation are already internal)
  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

@sfc-gh-pmotacki sfc-gh-pmotacki requested a review from a team as a code owner July 19, 2024 09:36
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title SNOW-1454054 - add check of user permision for token file SNOW-1454054: Add check of user permision for token file Jul 19, 2024
@sfc-gh-dprzybysz sfc-gh-dprzybysz changed the title SNOW-1454054: Add check of user permision for token file SNOW-1454054: Add check of user permission for token file Jul 19, 2024
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1454054-verify-token-file-permissions branch from e221b0f to 9661176 Compare July 19, 2024 13:04
@sfc-gh-pmotacki sfc-gh-pmotacki force-pushed the SNOW-1454054-verify-token-file-permissions branch from 9661176 to 785f216 Compare July 19, 2024 13:16
@sfc-gh-pmotacki sfc-gh-pmotacki enabled auto-merge (squash) July 22, 2024 07:14
@sfc-gh-pmotacki sfc-gh-pmotacki disabled auto-merge July 22, 2024 07:14
@sfc-gh-dprzybysz sfc-gh-dprzybysz merged commit 0c79467 into master Jul 22, 2024
141 checks passed
@sfc-gh-dprzybysz sfc-gh-dprzybysz deleted the SNOW-1454054-verify-token-file-permissions branch July 22, 2024 07:19
@github-actions github-actions bot locked and limited conversation to collaborators Jul 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants