Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-931788: Add codecov.yml to count partial hit #1562

Merged
merged 1 commit into from
Nov 16, 2023
Merged

SNOW-931788: Add codecov.yml to count partial hit #1562

merged 1 commit into from
Nov 16, 2023

Conversation

sfc-gh-ext-simba-jl
Copy link
Collaborator

Overview

SNOW-931788
https://github.com/snowflakedb/snowflake-sdks-drivers-issues-teamwork/issues/686

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #686

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl requested a review from a team as a code owner November 15, 2023 23:38
sfc-gh-igarish
sfc-gh-igarish approved these changes Nov 15, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfc-gh-ext-simba-jl sfc-gh-ext-simba-jl changed the title SNOW-931788: Add codecov.yml to enable partial hit SNOW-931788: Add codecov.yml to count partial hit Nov 15, 2023
@sfc-gh-igarish sfc-gh-igarish merged commit 3f678ff into master Nov 16, 2023
23 of 24 checks passed
@sfc-gh-igarish sfc-gh-igarish deleted the SNOW-931788-add-codecov-yml branch November 16, 2023 01:29
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-ext-simba-jl @sfc-gh-igarish