Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-834606 update test #1408

Merged
merged 1 commit into from
Jun 7, 2023
Merged

SNOW-834606 update test #1408

merged 1 commit into from
Jun 7, 2023

Conversation

sfc-gh-tyuan
Copy link
Collaborator

@sfc-gh-tyuan sfc-gh-tyuan commented Jun 7, 2023 •
edited
Loading

Overview

SNOW-834606
Updated the IntegrationTest system call logic in GS, updating the JDBC test here.

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

Add new argument to the system call

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-tyuan sfc-gh-tyuan requested a review from a team as a code owner June 7, 2023 20:26
sfc-gh-igarish
sfc-gh-igarish approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-tyuan sfc-gh-tyuan merged commit 013edca into master Jun 7, 2023
@sfc-gh-tyuan sfc-gh-tyuan deleted the tyuan-SNOW-834606-update-put-test branch June 7, 2023 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi Awaiting requested review from sfc-gh-hchaturvedi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-tyuan @sfc-gh-igarish