SNOW-806332 Fix test timeouts #1380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfc-gh-mknister
commented
May 4, 2023
| @@ -216,7 +216,7 @@ public void testExecuteLargeBatch() throws SQLException { | |||
|
|
|||
| @Test | |||
| public void testRemoveExtraDescribeCalls() throws SQLException { | |||
| Connection connection = getConnection(); | |||
| Connection connection = init(); | |||
There was a problem hiding this comment.
Forgot that for tests that run on both Arrow and Json (like PreparedStatement2LatestIT), we should always use init() instead of getConnection() because the setup logic for init() ensures we make the switch from json to arrow for the arrow extension IT tests. Fixed those too.
sfc-gh-mknister
commented
May 4, 2023
| @@ -317,30 +317,4 @@ public void testAlreadyDescribedMultipleResults() throws SQLException { | |||
| assertTrue(rs.next()); | |||
| assertTrue(prepStatement.unwrap(SnowflakePreparedStatementV1.class).isAlreadyDescribed()); | |||
| } | |||
|
|
|||
| @Test | |||
There was a problem hiding this comment.
Remove huge test. Mocked version is now in Update IT file instead.
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SNOW-806332
We are having test timeout failures where tests are running for over 2 hours. This looks to be because of 2 extremely long-running large update tests. The fix is to mock the response from the server to return a large long value instead of updating all of those rows for real.
External contributors - please answer these questions before submitting a pull request. Thanks!
Please answer these questions before submitting your pull requests. Thanks!
What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.
Fixes #NNNN
Fill out the following pre-review checklist:
Please describe how your code solves the related issue.
Please write a short description of how your code change solves the related issue.
Pre-review checklist