Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SNOW-761217 URL Encode OCSP Requests #1332

Merged
merged 2 commits into from
Apr 7, 2023
Merged

SNOW-761217 URL Encode OCSP Requests #1332

merged 2 commits into from
Apr 7, 2023

Conversation

sfc-gh-hchaturvedi
Copy link
Collaborator

Overview

SNOW-761217

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

  1. What GitHub issue is this PR addressing? Make sure that there is an accompanying issue to your PR.

    Fixes #NNNN

  2. Fill out the following pre-review checklist:

    • I am adding a new automated test(s) to verify correctness of my new code
    • I am adding new logging messages
    • I am modifying authorization mechanisms
    • I am adding new credentials
    • I am modifying OCSP code
    • I am adding a new dependency

  3. Please describe how your code solves the related issue.

    Please write a short description of how your code change solves the related issue.

Pre-review checklist

  • This change has passed precommit
  • I have reviewed code coverage report for my PR in (Sonarqube)

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi requested a review from a team as a code owner April 4, 2023 06:28
sfc-gh-wshangguan
sfc-gh-wshangguan reviewed Apr 4, 2023
View reviewed changes
Copy link
Contributor

@sfc-gh-wshangguan sfc-gh-wshangguan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for OCSP GET request similar to python? Or JDBC already has one?

sfc-gh-igarish
sfc-gh-igarish approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@sfc-gh-igarish sfc-gh-igarish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Double check if we need to add any log for URLencoded request, before and after.

@sonarqubemergegate
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sfc-gh-hchaturvedi sfc-gh-hchaturvedi merged commit 9832b08 into master Apr 7, 2023
@sfc-gh-hchaturvedi sfc-gh-hchaturvedi deleted the hchaturvedi_snow_761217 branch April 7, 2023 18:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sfc-gh-wshangguan sfc-gh-wshangguan sfc-gh-wshangguan left review comments

@sfc-gh-igarish sfc-gh-igarish sfc-gh-igarish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sfc-gh-hchaturvedi @sfc-gh-wshangguan @sfc-gh-igarish