Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SNOW-683245 and format the file #1188

Merged
merged 3 commits into from
Nov 15, 2022
Merged

Fix SNOW-683245 and format the file #1188

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
66973b4
Fix SNOW-683245 and format the file
sfc-gh-igarish Nov 9, 2022
8a00b7f
Enable the test
sfc-gh-igarish Nov 12, 2022
b9b2029
Merge branch 'master' into igarish-SNOW-683245-GCS-DOWNSCOPE-TOKEN
sfc-gh-igarish Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/main/java/net/snowflake/client/jdbc/cloud/storage/SnowflakeGCSClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,8 @@ public void download(
}

logger.debug("Starting download without presigned URL", false);
blob.downloadTo(localFile.toPath());
blob.downloadTo(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there test coverage for this? Or are there any existing tests that this would affect?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We change the way we access GCS. So existing tests will do.

Copy link
Contributor

@sfc-gh-wshangguan sfc-gh-wshangguan Nov 10, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is not a behavior change? Does JDBC do the decompression somewhere else previously? @sfc-gh-igarish

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No behavior change. In the same method below it does decompression. So download file as is and then decompress locally.Same logic as pre-signed url.

localFile.toPath(), Blob.BlobSourceOption.shouldReturnRawInputStream(true));
logger.debug("Download successful", false);

// Get the user-defined BLOB metadata
Expand Down