Reset query status error code and error message after error #1094

SimbaGithub · 2022-07-15T16:43:42Z

Overview

SNOW-XXXXX

Description from #1005
enum QueryStatus has setErrorMessage and setErrorCode methods ref to put error message and error code.
Since Java's enum has single instance, if we change error message and error code these values will maintain permanently unless we call setErrorMessage and setErrorCode again.

External contributors - please answer these questions before submitting a pull request. Thanks!

Please answer these questions before submitting your pull requests. Thanks!

What GitHub issue is this PR adressing? Make sure that there is an accompanying issue to your PR.

Fixes SNOW-592831: enum QueryStatus keeps previous errorCode and errorMessage #1005
Fill out the following pre-review checklist:
- I am adding a new automated test(s) to verify correctness of my new code
- I am adding new logging messages
- I am modyfying authorization mechanisms
- I am adding new credentials
- I am modyfying OCSP code
- I am adding a new dependency
Please describe how your code solves the related issue.

If the query status is not an error, set the error code and error message back to default values so they don't retain the error code/message.

Pre-review checklist

This change has passed precommit
I have reviewed code coverage report for my PR in (Sonarqube)

format

sfc-gh-mknister · 2022-08-12T00:28:47Z

src/test/java/net/snowflake/client/jdbc/ConnectionLatestIT.java

+    status.setErrorCode(2003);
+    status = rs1.unwrap(SnowflakeResultSet.class).getStatus();
+    // Assert status of query is a success
+    assertEquals(QueryStatus.SUCCESS, status);


Looks good, except that the jenkins test server is a bit slow sometimes so this is coming back as RUNNING instead of SUCCESS. Putting in a brief thread sleep should fix this and prevent flaky tests. Something like a 3 second sleep timer.

sfc-gh-mknister

Please add a sleep timer in the test to prevent a flaky test scenario where the async query hasn't finished running before it's asserted to be a success!

Other than that, looks good, so approving assuming that line will be added.