Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against Python 3.10.0-alpha.5 #25

Closed
wants to merge 4 commits into from
Closed

Conversation

macbre
Copy link
Contributor

@macbre macbre commented Mar 4, 2021

@sondrelg - I guess it's worth testing against the upcoming Python version.

@sondrelg sondrelg self-requested a review March 4, 2021 11:38
@sondrelg
Copy link
Member

sondrelg commented Mar 4, 2021

Yeah 100%. The question, I guess, is whether it's an action issue or a Poetry issue when it fails 😅 Think I opened a similar PR a few weeks back and when the workflows failed, just figured I'd wait until the official release.

Feel free to tinker with this to see if there's anything that can be done on the action side of things 👏

@macbre
Copy link
Contributor Author

macbre commented Mar 4, 2021

https://github.com/snok/install-poetry/pull/25/checks?check_run_id=2030658818

ModuleNotFoundError: No module named 'cleo'

I get a quite similar error. You're right, it looks like something that needs to be fixed on poetry side.

@sondrelg
Copy link
Member

sondrelg commented Mar 4, 2021

Yeah looks like even 1.1.5 fails against Python 3.10 🤷‍♂️

@JWCook
Copy link

JWCook commented May 10, 2021

I also just ran into this on 3.10.0-beta.1. There are several issues and threads out there regarding this same error but with previous python versions. See python-poetry/poetry#553 and python-poetry/poetry#3345. It appears to be an issue with packages vendored by poetry, with a number of possible workarounds proposed in those linked issues. I'm not sure which of those (if any) would be the cleanest option to use here.

@sondrelg
Copy link
Member

If you've run into this issue using the action, this sounds like a good time to pick this PR back up and try to resolve it 🙂 Thanks for letting us know!

Are you running Poetry on 3.10.0-beta.1 outside of Github's runners @JWCook? Do we know if that works? I would imagine it does, but it seems like a good thing to make sure of before we dive into this properly - if you haven't run it on 3.10 I could test this myself

Looking at the threads you linked, I see the issues seem to be rooted in reinstalling Poetry which I wouldn't expect to be an issue here tbh, but there's no harm in testing the suggested workarounds anyway 👏

@JWCook
Copy link

JWCook commented May 10, 2021

I built python 3.10.0-beta.1 from source locally, and was able to install poetry with both python3.10 get-poetry.py and python3.10 -m pip install --user poetry. I got an unrelated error when trying to install with pipx install --python python3.10 poetry, but that might be something specific to my environment.

Fyi, I don't have an urgent need to use python 3.10. I was pretty much just thinking the same thing as @macbre: "Hey, why not add some tests with 3.10 and see what happens."

@sondrelg
Copy link
Member

Opened an upstream issue. Hopefully we're missing something obvious 🤞 🙂

@macbre macbre changed the base branch from main to v1.2 May 22, 2021 17:11
@macbre
Copy link
Contributor Author

macbre commented May 22, 2021

@sondrelg - rebased to v1.2 version branch (#33).

And tests do pass 🎉 - e.g, https://github.com/snok/install-poetry/pull/25/checks?check_run_id=2646756259

@macbre macbre marked this pull request as ready for review May 22, 2021 17:13
@sondrelg sondrelg closed this May 22, 2021
@sondrelg sondrelg deleted the branch snok:v1.2 May 22, 2021 18:07
@sondrelg
Copy link
Member

Not sure how I closed this - wasn't my intention @macbre, sorry 🙏 If you reopen I will merge

@sondrelg
Copy link
Member

Just point it at main🙂

@macbre macbre deleted the patch-2 branch May 22, 2021 18:18
@macbre macbre restored the patch-2 branch May 22, 2021 18:18
@macbre
Copy link
Contributor Author

macbre commented May 22, 2021

I do not have option to reopen this PR... I'll apply my change once again then.

@macbre macbre deleted the patch-2 branch May 22, 2021 18:18
macbre added a commit to macbre/install-poetry that referenced this pull request May 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants