-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against Python 3.10.0-alpha.5 #25
Conversation
Yeah 100%. The question, I guess, is whether it's an action issue or a Poetry issue when it fails 😅 Think I opened a similar PR a few weeks back and when the workflows failed, just figured I'd wait until the official release. Feel free to tinker with this to see if there's anything that can be done on the action side of things 👏 |
https://github.com/snok/install-poetry/pull/25/checks?check_run_id=2030658818
I get a quite similar error. You're right, it looks like something that needs to be fixed on |
Yeah looks like even 1.1.5 fails against Python 3.10 🤷♂️ |
I also just ran into this on 3.10.0-beta.1. There are several issues and threads out there regarding this same error but with previous python versions. See python-poetry/poetry#553 and python-poetry/poetry#3345. It appears to be an issue with packages vendored by poetry, with a number of possible workarounds proposed in those linked issues. I'm not sure which of those (if any) would be the cleanest option to use here. |
If you've run into this issue using the action, this sounds like a good time to pick this PR back up and try to resolve it 🙂 Thanks for letting us know! Are you running Poetry on 3.10.0-beta.1 outside of Github's runners @JWCook? Do we know if that works? I would imagine it does, but it seems like a good thing to make sure of before we dive into this properly - if you haven't run it on 3.10 I could test this myself Looking at the threads you linked, I see the issues seem to be rooted in reinstalling Poetry which I wouldn't expect to be an issue here tbh, but there's no harm in testing the suggested workarounds anyway 👏 |
I built python 3.10.0-beta.1 from source locally, and was able to install poetry with both Fyi, I don't have an urgent need to use python 3.10. I was pretty much just thinking the same thing as @macbre: "Hey, why not add some tests with 3.10 and see what happens." |
Opened an upstream issue. Hopefully we're missing something obvious 🤞 🙂 |
@sondrelg - rebased to v1.2 version branch (#33). And tests do pass 🎉 - e.g, https://github.com/snok/install-poetry/pull/25/checks?check_run_id=2646756259 |
Not sure how I closed this - wasn't my intention @macbre, sorry 🙏 If you reopen I will merge |
Just point it at main🙂 |
I do not have option to reopen this PR... I'll apply my change once again then. |
@sondrelg - I guess it's worth testing against the upcoming Python version.