Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix filemode of persisted crfsuite files #844

Merged
merged 5 commits into from
Aug 20, 2019
Merged

Conversation

adrienball
Copy link
Contributor

fix #835

@adrienball adrienball requested a review from ClemDoum August 19, 2019 17:15
@codecov-io
Copy link

Codecov Report

Merging #844 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.02%     
==========================================
  Files          79       79              
  Lines        5106     5109       +3     
  Branches      970      971       +1     
==========================================
+ Hits         4539     4541       +2     
  Misses        422      422              
- Partials      145      146       +1

8 similar comments
@codecov-io
Copy link

Codecov Report

Merging #844 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.02%     
==========================================
  Files          79       79              
  Lines        5106     5109       +3     
  Branches      970      971       +1     
==========================================
+ Hits         4539     4541       +2     
  Misses        422      422              
- Partials      145      146       +1

@codecov-io
Copy link

Codecov Report

Merging #844 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.02%     
==========================================
  Files          79       79              
  Lines        5106     5109       +3     
  Branches      970      971       +1     
==========================================
+ Hits         4539     4541       +2     
  Misses        422      422              
- Partials      145      146       +1

@codecov-io
Copy link

Codecov Report

Merging #844 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.02%     
==========================================
  Files          79       79              
  Lines        5106     5109       +3     
  Branches      970      971       +1     
==========================================
+ Hits         4539     4541       +2     
  Misses        422      422              
- Partials      145      146       +1

@codecov-io
Copy link

Codecov Report

Merging #844 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.02%     
==========================================
  Files          79       79              
  Lines        5106     5109       +3     
  Branches      970      971       +1     
==========================================
+ Hits         4539     4541       +2     
  Misses        422      422              
- Partials      145      146       +1

@codecov-io
Copy link

Codecov Report

Merging #844 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.02%     
==========================================
  Files          79       79              
  Lines        5106     5109       +3     
  Branches      970      971       +1     
==========================================
+ Hits         4539     4541       +2     
  Misses        422      422              
- Partials      145      146       +1

@codecov-io
Copy link

Codecov Report

Merging #844 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.02%     
==========================================
  Files          79       79              
  Lines        5106     5109       +3     
  Branches      970      971       +1     
==========================================
+ Hits         4539     4541       +2     
  Misses        422      422              
- Partials      145      146       +1

@codecov-io
Copy link

Codecov Report

Merging #844 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.02%     
==========================================
  Files          79       79              
  Lines        5106     5109       +3     
  Branches      970      971       +1     
==========================================
+ Hits         4539     4541       +2     
  Misses        422      422              
- Partials      145      146       +1

@codecov-io
Copy link

Codecov Report

Merging #844 into master will decrease coverage by 0.01%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.02%     
==========================================
  Files          79       79              
  Lines        5106     5109       +3     
  Branches      970      971       +1     
==========================================
+ Hits         4539     4541       +2     
  Misses        422      422              
- Partials      145      146       +1

@codecov-io
Copy link

codecov-io commented Aug 20, 2019

Codecov Report

Merging #844 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master     #844      +/-   ##
==========================================
- Coverage   88.89%   88.88%   -0.01%     
==========================================
  Files          79       79              
  Lines        5106     5112       +6     
  Branches      970      971       +1     
==========================================
+ Hits         4539     4544       +5     
  Misses        422      422              
- Partials      145      146       +1

@adrienball adrienball merged commit 35abee2 into master Aug 20, 2019
@adrienball adrienball deleted the fix/file-permission branch August 20, 2019 09:39
@ClemDoum ClemDoum mentioned this pull request Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong permission of crfsuite files when persisting engine
2 participants