Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use transformer for model files #16101

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Use transformer for model files #16101

merged 1 commit into from
Jan 20, 2025

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jan 20, 2025

This switches us to using transformer methods for asset model files.

Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Jan 20, 2025

PR Summary

  • Simplified Data Fetching in AssetModelFilesController
    A restructuring has been made on how we fetch asset uploads, making it simpler and more efficient by utilizing AssetModelsTransformer. Additionally, a small change on parameter naming enhances readability.

  • New Feature in AssetModelsTransformer
    A new functionality has been added, aptly named transformAssetModelFiles. This function transforms the data of asset uploads into a systematic array format.

  • Improved File Information Extraction
    The transformAssetModelFile method has been revised to extract more detailed file information, resulting in a comprehensive and structured response.

  • Updated API Response Structure in Tests
    Our test expectations have been refreshed to match our latest application changes. The expected JSON structure now includes rows and total instead of the previous payload.

  • Consistent JSON Structure Checks
    To ensure our data integrity, all API response tests now cross-check with the revamped JSON structure that includes status and messages. This makes sure our data maintains its expected format across the board.

@snipe snipe merged commit 752d89d into develop Jan 20, 2025
8 of 9 checks passed
@snipe snipe deleted the standarize_modelfile_api branch January 20, 2025 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant