Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update related asset when checkout acceptance created via factory #16051

Merged

Conversation

marcusmoore
Copy link
Collaborator

I noticed that creating pending checkout acceptances via the factory wasn't populating the Unaccepted Assets report page. This is because the assigned_to and assigned_type on assets are set in the CheckoutableListener when the full request is actually made.

This PR updates the factory to update the checked out asset. There is probably additional cases that should have similar behavior but this is focused on this specific case.

Copy link

what-the-diff bot commented Jan 9, 2025

PR Summary

  • Addition of Feature to Control Checkout Acceptance
    The code now includes an import statement for a new component called CheckoutAcceptance. This is a model or a template of sorts used in managing the checkout process.

  • New Functionality for Checkout Model Updates
    A new method named configure has been introduced. Its job is to keep an eye on the creation event of the checkout model. Basically, it initiates an action just after a checkout model is created. This action is to update attributes such as assigned_to and assigned_type, based on certain conditions. This can provide better management and control of individual checkouts.

@snipe snipe merged commit f0bcf78 into snipe:develop Jan 10, 2025
9 checks passed
@marcusmoore marcusmoore deleted the testing/checkoutable-acceptance-factory-fix branch January 13, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants