Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Included MAIL_FROM_ADDR in phpunit configuration #15910

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

marcusmoore
Copy link
Collaborator

Description

In #15839 I asked @Godmartinz to add MAIL_FROM_ADDR to .env.testing in order to get tests back to green. This worked but I really should have suggested adding it to phpunit.xml so future devs wouldn't have to notice the addition of the variable to .env.testing.example and add it locally themselves.

This PR does handles this better by included it in phpunit.xml.

Type of change

  • Chore?

@marcusmoore marcusmoore requested a review from snipe as a code owner December 2, 2024 18:27
Copy link

what-the-diff bot commented Dec 2, 2024

PR Summary

  • Removal of MAIL_FROM_ADDR from a Config File
    We have removed the email configuration MAIL_FROM_ADDR from a specific config file, .env.testing.example.
  • Introduction of MAIL_FROM_ADDR for Testing Environment
    We introduced the same email configuration in another file phpunit.xml. This change allows us to use a predetermined email address (app@example.com) during software testing, streamlining the testing process.

@snipe snipe merged commit 8ff099e into snipe:develop Dec 2, 2024
8 checks passed
@marcusmoore marcusmoore deleted the chore/include-testing-variable branch December 2, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants