Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed variable name to correctly log created_by and date for bulk user delete/checkin #15845

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Nov 19, 2024

We were using the wrong variable name for created_by which was therefore 1) not correctly logging the acting user, and also bonking the date on the asset checkin log.

Signed-off-by: snipe <snipe@snipe.net>
Copy link

what-the-diff bot commented Nov 19, 2024

PR Summary

  • Modification in Property Assignment
    The change involves assigning a different property to the 'logAction' in the 'logItemCheckinAndDelete' method. Instead of assigning 'created_at', the 'created_by' property is now being assigned. This could potentially affect who or what is identified as the creator in the logging process.

@snipe snipe merged commit d576016 into develop Nov 19, 2024
9 checks passed
@snipe snipe deleted the bug/sc-27523 branch November 19, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant