Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace the via() channel for MS Teams (deprecated) #15816

Merged
merged 1 commit into from
Nov 14, 2024
Merged

replace the via() channel for MS Teams (deprecated) #15816

merged 1 commit into from
Nov 14, 2024

Conversation

Godmartinz
Copy link
Collaborator

Description

This reverts the via method back to MicrosoftTeamsChannel.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

@Godmartinz Godmartinz requested a review from snipe as a code owner November 14, 2024 16:39
@what-the-diff What The Diff
Copy link

what-the-diff bot commented Nov 14, 2024

PR Summary

  • Notification Class Update
    We have updated the code in the CheckoutAssetNotification.php file. Previously, it was using TeamsNotification::class which was incorrect. Now it has been changed to MicrosoftTeamsChannel::class. This change is important because it will allow us to send notifications through Microsoft Teams properly.

@snipe snipe merged commit 306c97b into snipe:develop Nov 14, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snipe snipe Awaiting requested review from snipe snipe is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Godmartinz @snipe