FIXED: Bulk Delete page not showing full information

[akemidx]

Description

The Bulk Delete page had missing information:

1. showed user id instead of the person's name
2. showed incomplete information for a user's asset in they did not have a location set

Before:

After:

The location will be listed to match the location of the asset as it appears on the Assets index page.

Fixes # 26944

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

manual tests and test suite

• PHP version: 8.1
• OS version: Sonoma 14.6

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

• Updated Condition for Location Identification
  The update changes how we identify a location in our system. We are now using a specific 'location_id' instead of a generic 'location'. This improves the accuracy and efficiency of locating information.

• Added Clause to Check for Real-Time Data Location Identification
  An additional clause was added to check for 'rtd_location_id'. Now, if no specific location is provided, the system is capable of showing the default location name. This makes our interface more user-friendly and helps prevent confusion in case of missing data.

• Improvement in Task Assignment Identification
  The way we check and confirm task assignments has been enhanced by referencing 'assigned_to'. Furthermore, when displaying task assignment, we now use a more user-friendly name. This change enhances the clarity and readability of our information presentation.

[snipe]

Why was this line changed? There is a relationship ($asset->location) which is being checked for, which is generally better than just checking for the ID, since the ID could be invalid.

[akemidx]

so, the two things we were checking against are the location_id and the rtd_location_id. these are the two values in the assets table when we looked for location. currently, we are ending up with blanks for the location of an asset on the bulk delete page, this is weird behavior, since it won't match the assets index page. since through deployedLocationFormatter we return the row.name off the row.id, and if not, then we pull the rtd_location.name from the rtd_location.id. its this if/else that we tried to parity.

[snipe]

Right, but if the location_id or rtd_location_id reference a non-existent location (bad data, etc), that will 500. We should be checking against the relations to make sure those locations actually exist in the database.

[akemidx]

righto, i'll get to this on monday and get that switched over. ty for the explaination.

[snipe]

Looks like we've got some tests failing here - can you take a look?