Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch Exceptions on Checkout Notification #15532

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

spencerrlongg
Copy link
Collaborator

Description

Wrapped the notification in a simple try/catch to resolve #15253 - just putting the error in to logs right now, but we could return a different message, just not sure what kind of wording we'd want, and would have to change the order in which the CheckoutAccepted event is fired as well. Happy to do that, but not sure if it's needed/wanted and what kind of wording we'd want.

Fixes #15253

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Copy link

what-the-diff bot commented Sep 19, 2024

PR Summary

  • Exception Handling for Notifications
    The update introduces a new measure to handle unexpected circumstances when sending notifications. By wrapping the notification process in a 'try-catch' block, we are able to prevent any unforeseen errors from halting the entire operation.

  • Logging Exception Events
    In the event of failure or error during the notification process, the updated code will now keep a record in our logs. This will help the team in diagnosing the problem as they will have information about what exactly went wrong.

@snipe snipe merged commit cdb7ccb into snipe:develop Sep 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants