WIP - fixed #15439 - check db on healthcheck #15441
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure this is the right way to approach this, but it's a stab at it anyway. User is saying that the health check should check for database connection as well. I know we kept the health check out of the web middleware specifically so it didn't try to create a buttload of session files, but there might be a clearer approach, perhaps it's own middleware instead of
\App\Http\Middleware\CheckForSetup::class
.Tests are failing on index pages with a 401 though, even though it seems to work locally with Postman (which implies to me that the tests might wrong.)
Potential (WIP) fix for #15439.