Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing translations #15010

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Added missing translations #15010

merged 1 commit into from
Jul 3, 2024

Conversation

snipe
Copy link
Owner

@snipe snipe commented Jul 3, 2024

Found a few more hardcoded strings - this makes them translatable

Signed-off-by: snipe <snipe@snipe.net>
@snipe snipe changed the title Added missing traslations Added missing translations Jul 3, 2024
Copy link

what-the-diff bot commented Jul 3, 2024

PR Summary

  • Inclusion of a New Language Key
    An additional language key labelled more_info has been introduced, along with its corresponding string value More Info. This can be found in the file named resources/lang/en-US/general.php.

  • Improvement in Quickscan Interface
    Changes have been made to the Quickscan graphical layout in the resources/views/hardware/quickscan.blade.php file. These alterations involve modifying the data content of a certain link to use the general.quickscan_bulk_help language key, and adding the recently created general.more_info language key to the link's title attribute.

  • Refinement in More-info Section
    In the resources/views/partials/more-info.blade.php file, the title attribute of a specific link now employs the general.more_info language key. This change is intended to enhance the overall user experience of the More-info section.

@snipe snipe merged commit 4b97270 into develop Jul 3, 2024
8 of 9 checks passed
@snipe snipe deleted the fixes/translation_strings branch July 3, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant