Added #14426: Makes all Manufacturer links dynamic, not just warranty lookup

[DrekiDegga]

Description

As requested in #14470, I'm retargeting for develop branch. I couldn't find an easy way to do this so I just started over. Deleted, reforked, made changes against the develop branch and retested on testing environment with debugging enabled.

This makes all manufacturer links dynamic just like warranty lookup.

Added #14426

Type of change

• New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've tested working on latest from my test environment.

Test Configuration:

• PHP version: 7.4.33
• MySQL version 10.11.4-MariaDB-1~deb12u1 Debian 12
• Webserver version apache2 2.4.56-1~deb11u2
• OS version Debian 12

Checklist:

• I have read the Contributing documentation available here: https://snipe-it.readme.io/docs/contributing-overview
• I have formatted this PR according to the project guidelines: https://snipe-it.readme.io/docs/contributing-overview#pull-request-guidelines
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• New and existing unit tests pass locally with my changes

[what-the-diff]

PR Summary

• Extension of URL Validation Range
  Manufacturers URLs can now start with a variety of protocols, such as http://, https://, afp://, facetime://, file://, or irc://. This increased valid startings gives more flexibility to input URLs for manufacturers.

• Method Renaming and Updating
  The method previously named dynamicWarrantyUrl() is now dynamicUrl(), and it has been enhanced to be more flexible. It now takes a parameter to replace placeholders with user intending values, thereby increasing its usability.

• Updates in Asset's Display Page

  • We have improved how we handle URLs in the display page. Now, we are checking whether the URL is not empty, instead of it merely not being null.
  • The displayed links for the manufacturer's URL, support URL, and warranty lookup URL are dynamically generated now for more accuracy and consistency. External link icons have been added next to these URLs for a better visual cue.

[DrekiDegga]

Please let me know if there's a better way to do this or if there's anything else I can do to get this merged. @snipe

Thanks.

[DrekiDegga]

Here's a screenshot of this currently working on my test environment.

I've made no changes to the font icons or accessibility.

[snipe]

We do actually have to keep the model check here, in case someone deleted a model directly from the database. In that case, ($asset->model->manufacturer) will 500, since we're looking for a property on a relationship that doesn't exist.

[snipe]

One small change, but otherwise this looks good!

[snipe]

Never heard back from you. I'm going to accept this PR and make that change myself. Thanks!

[welcome]

Congrats on merging your first pull request! 🎉🎉🎉