API: POST /locations parent_id validation fails silently

[StarlessNights]

Debug mode

• I have enabled debug mode
• I have read checked the Common Issues page

Describe the bug

When POSTing¹ a new location through the api, an invalid parent_id parameter is ignored silently.

Reproduction steps

POST a new location with a nonexistent parent_id:

{
  "name": "New location",
  "parent_id": -5
}

The request will succeed, but the created location doesn't have parent set.

Expected behavior

The request should return a failure indicating that the parent_id was invalid. It already does this with invalid manager_id:

{
  "status": "error",
  "messages": {
    "manager_id": [
      "The selected manager id is invalid."
    ]
  },
  "payload": null
}

Screenshots

No response

Snipe-IT Version

7.0.10

Operating System

Ubuntu (Container)

Web Server

Apache

PHP Version

8.1

Operating System

No response

Browser

No response

Version

No response

Device

No response

Operating System

No response

Browser

No response

Version

No response

Error messages

No response

Additional context

Container in Kubernetes.

Footnotes

1. Likely this affects PUT and PATCH operations as well. ↩