Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: extract electronBeamEnergy MS term #303

Merged
merged 1 commit into from
Feb 6, 2025
Merged

feat: extract electronBeamEnergy MS term #303

merged 1 commit into from
Feb 6, 2025

Conversation

jorainer
Copy link
Collaborator

This PR extracts also the MS Term MS:1003410 (MS_electron_beam_energy).

@jorainer jorainer requested a review from sneumann January 24, 2025 12:38
@jorainer jorainer mentioned this pull request Jan 24, 2025
Closed
@sneumann sneumann merged commit fbfd6c9 into sneumann:devel Feb 6, 2025
2 of 3 checks passed
@sneumann
Copy link
Owner

sneumann commented Feb 6, 2025

Thanks a lot, looks good to me. Yours, Steffen

@sneumann
Copy link
Owner

sneumann commented Feb 6, 2025

Just realised this breaks test_header_all, since (by design) only pwiz returns electronBeamEnergy.
Regarding the issue #238
We probably shouldn't check for checkEquals(colnames(header_cdf), colnames(header_pwiz))
but ensure that all required columns for copyWriteMSData() exist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sneumann sneumann Awaiting requested review from sneumann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorainer @sneumann