-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing column names of chromatogram data.frames #304
Comments
I think this would be a good change, to align the headings with the spectra data. |
Would we know any users for which this would be a breaking change ? Yours, Steffen |
it would break a unit test of Nils @nilshoffmann :) - apart from that, the only place that I know uses the |
- data.frames returned by `chromatogram()` have column names `"rtime"` and `"intensity"` (issue sneumann#304).
Hi,
Would it be possible to have the
chromatogram()
data.frames column names changed to "rtime" and "intensity" ? instead of "time" and their respective IDsCurrently implementing a mzR backend in
Chromatograms
and this change would really help efficiency so i would not need to loop through all the data.frames in the list only to change the colnames. These names are also inxcms
(rtime()
/intensity()
) andSpectra
(spectraVariables) so it would be better for consistency.The text was updated successfully, but these errors were encountered: