test(ivc): impl fold_instances_test
#98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22bde28 to
97262a5
Compare
ea6cff5 to
10d2d93
Compare
85950ea to
81cbab5
Compare
10d2d93 to
f72c245
Compare
81cbab5 to
df4e546
Compare
chaosma
reviewed
Jan 11, 2024
| @@ -574,23 +620,10 @@ where | |||
| config: &MainGateConfig<T>, | |||
| mut ro_circuit: impl ROCircuitTrait<C::Base>, | |||
| public_params_hash: &C::Base, | |||
| instance: &PlonkInstance<C>, | |||
| input_plonk: &PlonkInstance<C>, | |||
There was a problem hiding this comment.
Considering how many times I've been confused between instance & instance.instance I'd say this title is a bit confusing
| @@ -297,3 +299,31 @@ macro_rules! create_and_verify_proof { | |||
| pub(crate) fn get_power_of_two_iter<F: ff::PrimeField>() -> impl Iterator<Item = F> { | |||
| iter::successors(Some(F::ONE), |l| Some(l.double())) | |||
| } | |||
|
|
|||
| pub(crate) struct CellsValuesView<'l, F: PrimeField> { | |||
There was a problem hiding this comment.
Is the main purpose of this struct to debug?
There was a problem hiding this comment.
Yes, to write important nuances to logs and debug info without a huge amount of garbage.
| let mut on_circuit_instances_cell = None; | ||
|
|
||
| // Run twice for setup & real run | ||
| for _ in 0..=1 { |
There was a problem hiding this comment.
please remove the for _ in 0..=1 which is not necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs & test & logs for
fold_instancesPart of #32