fix(bn): limbs limit in assign_sum
#94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f83509 to
4c35bf7
Compare
chaosma
reviewed
Jan 10, 2024
| @@ -150,20 +150,24 @@ impl<F: ff::PrimeField> BigUintMulModChip<F> { | |||
| big_uint::nat_to_f::<F>(&big_uint::get_big_int_with_n_ones(self.limb_width.get())) | |||
| .unwrap_or_default(); | |||
|
|
|||
| let (rhs_cells, rhs_tail) = rhs_cells.split_at(self.limbs_count_limit.get()); | |||
| if rhs_cells.len() > self.limbs_count_limit.get() { | |||
There was a problem hiding this comment.
can you explain why previous will panic at split_at? Do you mean rhs_tail.iter() will panic?
There was a problem hiding this comment.
Panic here
Len of sum result is less, then limbs limit & panic because of that
There was a bug if exactly limbs_count of elements was obtained while calculating the sum, then panic on `split_at` would fall. Now this check for zero tail is optional.
4c35bf7 to
5879d9d
Compare
chaosma
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug if exactly limbs_count of elements was obtained while calculating the sum, then panic on
split_atwould fall. Now this check for zero tail is optional.