-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ivc): cyclefold::ivc i
-step test
#407
Conversation
**Motivation** First part of tests of #373 **Overview** WIP
**Motivation** The `unchecked_add` calls were not previously tested. The problem is that `unsafe fn unchecked_add` should be called only if p.x != q.x That is, not the result should be used only if the condition is met, but the function should be called only if the condition is met **Overview** I added conditional one-one & two-two points to substitute them with conditional select. This way the call is always safe
i
-step test
WIP: test for `e`
wip: at this point I used the hack to fix the error, but it was in different offsets for pp.S and for any of the counted witnesses. The problem is that it is not clear how to count the primary input, now I am counting it twice and still on the last step it needs to be updated secondary. This commit will need to be rolled back and counted separately by doing the num_challenge calculation separately and it is worth considering that it depends on the sangria version of gates Also need to correct the passing in support_circuit of non-zero W's at the pp and ivc::new stage. previously zero was used, but the initial acc value should be the initiating trace, not something new
d6444bd
to
483cf81
Compare
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
1f8d297
to
734f5d7
Compare
Issue Link / Motivation
Part of #373, working first step of cyclefold::ivc
Changes Overview
WIP