Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ivc): cyclefold::ivc i-step test #407

Closed
wants to merge 32 commits into from
Closed

feat(ivc): cyclefold::ivc i-step test #407

wants to merge 32 commits into from

Conversation

cyphersnake
Copy link
Collaborator

@cyphersnake cyphersnake commented Dec 19, 2024 •
edited
Loading

Issue Link / Motivation
Part of #373, working first step of cyclefold::ivc

Changes Overview
WIP

@cyphersnake
test(ivc): cyclefold ivc zero step
3c519bf 
**Motivation**
First part of tests of #373

**Overview**
WIP
@cyphersnake
feat(gadgets): support of infinity point in ecc::scalar_mul
6c8d619
@cyphersnake
fix: cyclefold errors
8ef78b6
@cyphersnake
chore(ivc): cyclefold::sangria logs
94cea97
@cyphersnake
chore(ivc): commitment key cache for tests
7bc40bd
@cyphersnake
chore: fmt
ce31180
@cyphersnake
chore: logs
2ca2f2b
@cyphersnake
fix(ecc): unchecked_add call in ecc::add
d50cfc9 
**Motivation**
The `unchecked_add` calls were not previously tested. The problem is that `unsafe fn unchecked_add` should be called only if p.x != q.x

That is, not the result should be used only if the condition is met, but the function should be called only if the condition is met

**Overview**
I added conditional one-one & two-two points to substitute them with conditional select. This way the call is always safe
@cyphersnake
fix(ivc): consistent limbs count in cyclefold
3391c38
@cyphersnake
fix(ivc): cyclefold pairing check for zero step
a4334b7
@cyphersnake
feat(ivc): store in cyclefold ivc all acc-s
a683f4b
@cyphersnake
feat(ivc): impl cyclefold::ivc::next_step
87939db
@cyphersnake cyphersnake self-assigned this Dec 19, 2024
@cyphersnake cyphersnake changed the title 373 test first step feat(ivc): cyclefold::ivc first step test Dec 19, 2024
@cyphersnake cyphersnake changed the title feat(ivc): cyclefold::ivc first step test feat(ivc): cyclefold::ivc i-step test Dec 25, 2024
@cyphersnake
fix(ivc): order of absorbing cyclefold::sangria::acc
5456ea8
@cyphersnake
feat(ivc): impl cyclefold::verify
0f69c0b 
WIP: test for `e`
@cyphersnake
fix(nifs): consistency of prover/verifier params absorb
beb5609
@cyphersnake
test(ivc): additional nifs check for cfg(test)
191f0a5
@cyphersnake
test(nifs): merkle circuit
605d470
@cyphersnake
fix(ivc): consisteny plonk structure
483cf81 
wip:
at this point I used the hack to fix the error, but it was in different
offsets for pp.S and for any of the counted witnesses. The problem is
that it is not clear how to count the primary input, now I am counting
it twice and still on the last step it needs to be updated secondary.

This commit will need to be rolled back and counted separately by doing
the num_challenge calculation separately and it is worth considering
that it depends on the sangria version of gates

Also need to correct the passing in support_circuit of non-zero W's at
the pp and ivc::new stage. previously zero was used, but the initial acc
value should be the initiating trace, not something new
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Jan 7, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@cyphersnake cyphersnake changed the base branch from 373-test-zero-step to 372-feat-cyclefold-pp January 8, 2025 13:28
@cyphersnake cyphersnake closed this Jan 8, 2025
@cyphersnake cyphersnake deleted the 373-test-first-step branch February 17, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@cyphersnake cyphersnake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cyphersnake