Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ivc): cyclefold::pairing_check #400

Closed
wants to merge 0 commits into from
Closed

feat(ivc): cyclefold::pairing_check #400

wants to merge 0 commits into from

Conversation

cyphersnake
Copy link
Collaborator

Motivation
As part of impl of sfc (#369) we delegate ecc_scalar_mul computing to a suppport circuit. Within primary sfc we must validate the input of it and reuse the output to use as W_commitment protogalaxy_accumulator

Overview

  • I use the lagrange coefficients that we have already evaluated inside protogalaxy::verify, but with decompose into bn form
  • Change order of fields inside SupportCircuit
  • Little refactor protogalaxy::verify_chip

@cyphersnake cyphersnake requested a review from chaosma December 3, 2024 15:05
@cyphersnake cyphersnake self-assigned this Dec 3, 2024
@cyphersnake
Copy link
Collaborator Author

Close #370

Copy link
Collaborator

@chaosma chaosma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

NBD: pairing denotes to the pairing function in elliptic curves:e(a,b)
pairing check usually means the final ecc pairing check: e(lhs,rhs)=e(lhs1,rhs1).

Base automatically changed from 369-sfc-7 to main December 16, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants