feat(ivc): impl sangria::verify in cyclefold #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
678d10f to
5e439b2
Compare
2bc60b5 to
caeee87
Compare
5e439b2 to
dc40827
Compare
|
Close #368 |
chaosma
reviewed
Dec 12, 2024
We have a sangria chip that we want to reuse here, but the interface doesn't fit one-to-one, so we make the adapter pattern |
chaosma
approved these changes
Dec 13, 2024
caeee87 to
a8b7be5
Compare
**Motivation** During the implementation of #369, the types for protogalaxy & cyclefold differed in form but not in substance **Overview** Simple refactoring with removing identical structures and using in ivc::cyclefold types from ivc::protogalaxy
**Motivation** In #369 we have to minimize the paired circuit with sangria **Overview** I've reused almost all fold-fn (except `instance`) from the existing sangria implementation
dc40827 to
0201d35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In #369 we have to fold the paired circuit with sangria
Overview
I've reused almost all fold-fn (except
instance) from the existing sangria implementationTests will be in the next PRs