feat(ivc): impl protogalaxy::verify_sps
#385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaosma
reviewed
Nov 5, 2024
c86dd81 to
164ed63
Compare
0f2d330 to
4384df6
Compare
164ed63 to
8599c8d
Compare
4384df6 to
aa82d4b
Compare
chaosma
approved these changes
Nov 5, 2024
8599c8d to
6b554e0
Compare
Base automatically changed from
361-feat-protogalaxy-verify-circuit-9
to
361-feat-protogalaxy-verify-circuit-7
November 5, 2024 13:45
732980d to
7671e98
Compare
Base automatically changed from
361-feat-protogalaxy-verify-circuit-7
to
main
November 5, 2024 13:47
**Motivation** For fold instances in #361 we need Li(X) **Overview** Little refactor
**Motivation** Last part of #361 **Overview** Unlike the rest of the functionality, this one is untested because the test would need a cyclic curve and that makes the tests very difficult. It is better to test this part of e2e already in its entirety
**Motivation** Part of #361 **Overview** All that's left is to test this code separately from the rest. This requires cyclic curves, so I'm putting this part aside and going to make a cyclefold billet to build all types once
**Motivation** Close #367 **Overview** Tests for this functionality will be done within a more upper-level module to simplify the mocks
aa82d4b to
61661b0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close #367
Overview
Tests for this functionality will be done within a more upper-level module to simplify the mocks