feat(ivc): impl protogalaxy::fold_instances
#383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5fb1541 to
2b073fd
Compare
ac985f1 to
28aff98
Compare
**Motivation** For fold instances in #361 we need Li(X) **Overview** Little refactor
**Motivation** Last part of #361 **Overview** Unlike the rest of the functionality, this one is untested because the test would need a cyclic curve and that makes the tests very difficult. It is better to test this part of e2e already in its entirety
2b073fd to
d4aeffd
Compare
chaosma
reviewed
Nov 5, 2024
chaosma
approved these changes
Nov 5, 2024
dbf7415
into
361-feat-protogalaxy-verify-circuit-7
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Last part of #361
Overview
Unlike the rest of the functionality, this one is untested because the test would need a cyclic curve and that makes the tests very difficult.
It is better to test this part of e2e already